Fix label treatment of related charms #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
force-pushed
the
feature/fix-label-overwrite
branch
from
ec4cf6f to
e4d507f
Compare
sed-i
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
PietroPasotti and
simskij
as code owners
|
@rgildein if you're able to test this change, |
Abuelodelanada
approved these changes
Feb 26, 2024
dstathis
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This charm overwrites existing topology labels with its own topology labels. This happens because:
Solution
Fixes #275.
Context
This PR goes in tandem with:
Testing Instructions
See canonical/loki-k8s-operator#353.
Upgrade Notes
No change further action beyond
juju refreshis needed – labels should be corrected after an upgrade.